feat: instrument with prometheus #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id
force-pushed
the
20240905-instrument-with-prometheus
branch
from
f485ea4 to
e7c2dd8
Compare
qzhuyan
approved these changes
Sep 5, 2024
zmstone
reviewed
Sep 5, 2024
id
force-pushed
the
20240905-instrument-with-prometheus
branch
2 times, most recently
from
92c2e4c to
e65a8fc
Compare
id
force-pushed
the
20240905-instrument-with-prometheus
branch
from
e65a8fc to
304dd56
Compare
thalesmg
approved these changes
Sep 5, 2024
Comment on lines
+106
to
+110
| --restapi Enable REST API for monitoring and control. | ||
| For now only serves /metrics. | ||
| Can be set to IP:Port to listen on a specific IP and Port, | ||
| or just Port to listen on all interfaces on | ||
| that port. [default: disabled] |
There was a problem hiding this comment.
Suggested change
| --restapi Enable REST API for monitoring and control. | |
| For now only serves /metrics. | |
| Can be set to IP:Port to listen on a specific IP and Port, | |
| or just Port to listen on all interfaces on | |
| that port. [default: disabled] | |
| --restapi Enable REST API for monitoring and control. | |
| Only takes effect if Prometheus is enabled. | |
| For now only serves /metrics. | |
| Can be set to IP:Port to listen on a specific IP and Port, | |
| or just Port to listen on all interfaces on | |
| that port. [default: disabled] |
?
There was a problem hiding this comment.
Only takes effect if Prometheus is enabled.
I was thinking to add other functionality later, like change config in runtime without restart. Could be useful if you already have 1M connections and don't want to redo them again.
Comment on lines
+1284
to
+1300
| Counters = [ publish_latency | ||
| , recv | ||
| , sub | ||
| , sub_fail | ||
| , pub | ||
| , pub_fail | ||
| , pub_overrun | ||
| , pub_succ | ||
| , connect_succ | ||
| , connect_fail | ||
| , connect_retried | ||
| , reconnect_succ | ||
| , unreachable | ||
| , connection_refused | ||
| , connection_timeout | ||
| , connection_idle | ||
| ], |
There was a problem hiding this comment.
Nit: maybe we could move this list of counter names to a counter_name/0 function, and use it both here and in counters/0?
There was a problem hiding this comment.
Will do in the next PR. There are a few more things to deduplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.